Views secondary action links escapes html twice

Yes, here the whole strings are escaped, so we don't really need to escape the display titles first. I thought we already fixed this once before to be honest.

Really?! of a non escaped string? I think it just needs manual testing.

2: 2100959.patch queued for re-testing.

2: 2100959.patch queued for re-testing.

Tested manually and works pretty well except for 'Enable @display_title'.

I think we should be able to write a test for this.

• Fixed the remaining double-escaped drop-down button (Enable ...)
• Added tests

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/DisplayTest.php
@@ -327,4 +327,26 @@ public function testViewStatus() {
+    $this->assertFieldByXpath('//input[@type="submit"]', t('Clone !display_title', array('!display_title' => $display_title)));

How about we replace this placeholder array for a variable, and just reuse that for all of these assertions?

Other that that, looking good! Thanks for writing some tests for this. I forgot about this issue :)

I'll go. Let's get this done.

Don't think we need a screenshot either, we have one showing the initial issue. Plus, I think most people know what double escaped html looks like.

Committed and pushed to 8.x. Thanks!