Closed (outdated)
Project:
Commerce DPS
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Sep 2013 at 19:49 UTC
Updated:
28 Sep 2016 at 20:04 UTC
Jump to comment: Most recent
Comments
Comment #1
xurizaemonHappy for this to happen, will need someone to step up with contribution or sponsorship. Please use this issue to muster support!
Comment #2
garethhallnz commentedThis has been ported to it's own module and is currently awaiting approval
See https://drupal.org/node/2199857
Comment #3
xurizaemonThanks Gareth. If that module gets approved, please close this as a dupe. It looks like the submitted module has a fair bit of shared code & I'm open to it being added here if you see benefits to combining efforts rather than duplication. Eg we'd move shared functions like _currencies() and _generate_xml() (as appropriate) to commerce_dps.inc, and keep processor-specific functions in commerce_dps_pxpay.inc, commerce_dps_account_2_account.inc.
Comment #4
garethhallnz commentedHey Chris
Yes combining the 2 modules is a great idea as so much of the code is shared.
That said for the time being I just want to focus on getting the module approved; after that we can tackle this task.
I think we should aim for that in a 2.x release?
Comment #5
xurizaemonIf submitted as a patch here, I'm happy for A2A to go into Commerce DPS. (Bonus points for separately submitting the SimpleXML patch to PxPay!)
Comment #6
johnpitcairn commentedOops. Posted an issue for that module: #2680773: Merge with Commerce DPS module?
I think it looks like it would integrate pretty well into 1.x, the PxPost submodule is already in there.
Is anyone planning to work on this?
Comment #7
garethhallnz commentedSince PXPay have been deprecated and PXPay 2 supports account to account our of the box i no longer makes sense to merge these projects.