When using derivatives pluginDefinition['id'] has the base plugin id, not the compiled derivative id. If the default is provided by a derivative this could fail.

CommentFileSizeAuthor
#2 interdiff.txt1.34 KBdawehner
#2 local_task-2100651-2.patch2.58 KBdawehner
#2 local_task-2100651-FAIL.patch1.92 KBdawehner
#1 local_task-2100651-1.patch1.77 KBdawehner
local_tasks_plugin_id_fix.patch673 bytesneclimdul

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHPUnit
StatusFileSize
new local_task-2100651-1.patch1.77 KB

Also extended with a unit test.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new local_task-2100651-FAIL.patch1.92 KB
new local_task-2100651-2.patch2.58 KB
new interdiff.txt1.34 KB

.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, local_task-2100651-FAIL.patch, failed testing.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Reviewed & tested by the community

ding! with a test and everything. Thanks dawehner!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ding!

Committed and pushed to 8.x. Thanks. :D

Automatically closed -- issue fixed for 2 weeks with no activity.