When using derivatives pluginDefinition['id'] has the base plugin id, not the compiled derivative id. If the default is provided by a derivative this could fail.

Files: 
CommentFileSizeAuthor
#2 interdiff.txt1.34 KBdawehner
#2 local_task-2100651-2.patch2.58 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,905 pass(es).
[ View ]
#2 local_task-2100651-FAIL.patch1.92 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 59,331 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 local_task-2100651-1.patch1.77 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,905 pass(es).
[ View ]
local_tasks_plugin_id_fix.patch673 bytesneclimdul
PASSED: [[SimpleTest]]: [MySQL] 59,269 pass(es).
[ View ]

Comments

dawehner’s picture

Status:Needs review» Reviewed & tested by the community
Issue tags:+phpunit
StatusFileSize
new1.77 KB
PASSED: [[SimpleTest]]: [MySQL] 58,905 pass(es).
[ View ]

Also extended with a unit test.

dawehner’s picture

StatusFileSize
new1.92 KB
FAILED: [[SimpleTest]]: [MySQL] 59,331 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new2.58 KB
PASSED: [[SimpleTest]]: [MySQL] 58,905 pass(es).
[ View ]
new1.34 KB

.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, local_task-2100651-FAIL.patch, failed testing.

neclimdul’s picture

Status:Needs work» Reviewed & tested by the community

ding! with a test and everything. Thanks dawehner!

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Ding!

Committed and pushed to 8.x. Thanks. :D

Automatically closed -- issue fixed for 2 weeks with no activity.