This issues shows that comma at the end are not necessary:

#2002726-19: Remove unused local variables from core/includes/menu.inc
#2062213-12: Remove Unused local variable $scheme from /core/lib/Drupal/Core/StreamWrapper/LocalStream.php

so this issue is to clean it up some files and delete the comma.

CommentFileSizeAuthor
#6 core-clean-up-list-function-2099347-6.patch2.18 KBruloweb
#3 core-clean-up-list-function-2099347-3.patch2.26 KBruloweb
#1 core-clean-up-list-function-2099347-1.patch2.23 KBruloweb

Comments

ruloweb’s picture

ruloweb commented
Status: Active » Needs review
StatusFileSize
new core-clean-up-list-function-2099347-1.patch2.23 KB

I found the comma at the end in three files:

core/modules/file/file.views.inc
core/modules/image/image.views.inc
core/modules/taxonomy/taxonomy.views.inc

and created a patch xD

Status: Needs review » Needs work

The last submitted patch, core-clean-up-list-function-2099347-1.patch, failed testing.

ruloweb’s picture

ruloweb commented
Status: Needs work » Needs review
StatusFileSize
new core-clean-up-list-function-2099347-3.patch2.26 KB

Re-rolling.

scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community

These cleanups make sense to me. Thanks @ruloweb for working on that during the DrupalCon core sprint :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Quick fix

Nice clean-up!

Unfortunately, no longer applies. I can haz a re-roll? :)

ruloweb’s picture

ruloweb commented
Status: Needs work » Needs review
StatusFileSize
new core-clean-up-list-function-2099347-6.patch2.18 KB

Re-rolling again xD.

scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community

back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Title: Clean up list function » Clean up list function usage
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.