Part of #2096783: [META] Clean up Views plugin classes

CommentFileSizeAuthor
#3 2099343-2.patch5.82 KBdamiankloip
#3 interdiff-2099343-2.txt721 bytesdamiankloip
vdc.clean-relationship-plugins.patch5.82 KBdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks pretty decent!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
@@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
+  /**
+   * {@inheritdoc}
+   */
+  public function defineOptions() {
+    return array();
+  }

    Should this not be protected like the implementation it is overriding in RelationshipPluginBase 

  2. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
@@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
+  public function query() {
+  // No query to run.
+  }

    Wrong indentation.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2099343-2.txt721 bytes
new 2099343-2.patch5.82 KB

Eagle.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Alex the eagle

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

LOL :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.