Files: 
CommentFileSizeAuthor
#3 2099343-2.patch5.82 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,803 pass(es).
[ View ]
#3 interdiff-2099343-2.txt721 bytesdamiankloip
vdc.clean-relationship-plugins.patch5.82 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,638 pass(es).
[ View ]

Comments

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Looks pretty decent!

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
  1. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
    @@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
    +  /**
    +   * {@inheritdoc}
    +   */
    +  public function defineOptions() {
    +    return array();
    +  }

    Should this not be protected like the implementation it is overriding in RelationshipPluginBase

  2. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
    @@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
    +  public function query() {
    +  // No query to run.
    +  }

    Wrong indentation.

damiankloip’s picture

Status:Needs work» Needs review
StatusFileSize
new721 bytes
new5.82 KB
PASSED: [[SimpleTest]]: [MySQL] 58,803 pass(es).
[ View ]

Eagle.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Alex the eagle

webchick’s picture

Status:Reviewed & tested by the community» Fixed

LOL :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.