Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
locale.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
26 Sep 2013 at 15:57 UTC
Updated:
29 Jul 2014 at 22:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tstoecklerHere we go.
Comment #3
gábor hojtsyThis is a blocker for #2097101: Remove deprecated functions , which is a blocker for #1952394: Add configuration translation user interface module in core.
Comment #4
sxnc commentedComment #5
sxnc commentedComment #6
gábor hojtsyRe-uploading for testbot sanity. We need it to return data for us.
Comment #8
tstoecklerI don't think that #5/#6 are the correct fix.
Gábor explained that there's a problem with empty config files because they get imported and also their schema is getting parsed. This seems to be the problem. I've removed those files. So we can't test the hasTranslation() behavior with empty translation files, but we can't have empty translation files without other stuff failing anyway, so I think that's OK.
Sorry @sxnc for taking this over, hope that's OK.
Let's see if that passes.
Comment #9
gábor hojtsyLooks good! Reviewed in person.
Comment #10
sxnc commented@tstoeckler np! i thought i had it fixed but its good to see what the actual problem was, thanks a lot! :)
Comment #11
webchickDoesn't seem to apply for me. :(
Comment #12
gábor hojtsy#8: 2098697-locale-has-translation-8.patch queued for re-testing.
Comment #13
gábor hojtsy#8: 2098697-locale-has-translation-8.patch queued for re-testing.
Comment #14
gábor hojtsyStill applies/passes with the testbot in the past 2 days. @webchick can you try again? :) Thanks!
Comment #15
webchickHuh. No idea what that was about.
Committed and pushed to 8.x. Thanks!
Comment #16
gábor hojtsyThanks a lot! Woot!