Updated: Comment #0
Problem/Motivation
For config_translation.module we need a way to check whether a translation exists for a certain config name. This is only related to the locale override system and is not related to the config translation system in particular, so it should not be added there.
Proposed resolution
Add a "hasTranslation()" utility method to LocaleConfigManager.
Comments
Comment #1
tstoecklerHere we go.
Comment #3
Gábor HojtsyThis is a blocker for #2097101: Remove deprecated functions , which is a blocker for #1952394: Add configuration translation user interface module in core.
Comment #4
sxnc CreditAttribution: sxnc commentedComment #5
sxnc CreditAttribution: sxnc commentedComment #6
Gábor HojtsyRe-uploading for testbot sanity. We need it to return data for us.
Comment #8
tstoecklerI don't think that #5/#6 are the correct fix.
Gábor explained that there's a problem with empty config files because they get imported and also their schema is getting parsed. This seems to be the problem. I've removed those files. So we can't test the hasTranslation() behavior with empty translation files, but we can't have empty translation files without other stuff failing anyway, so I think that's OK.
Sorry @sxnc for taking this over, hope that's OK.
Let's see if that passes.
Comment #9
Gábor HojtsyLooks good! Reviewed in person.
Comment #10
sxnc CreditAttribution: sxnc commented@tstoeckler np! i thought i had it fixed but its good to see what the actual problem was, thanks a lot! :)
Comment #11
webchickDoesn't seem to apply for me. :(
Comment #12
Gábor Hojtsy#8: 2098697-locale-has-translation-8.patch queued for re-testing.
Comment #13
Gábor Hojtsy#8: 2098697-locale-has-translation-8.patch queued for re-testing.
Comment #14
Gábor HojtsyStill applies/passes with the testbot in the past 2 days. @webchick can you try again? :) Thanks!
Comment #15
webchickHuh. No idea what that was about.
Committed and pushed to 8.x. Thanks!
Comment #16
Gábor HojtsyThanks a lot! Woot!