Change KeyValueFactory to use Settings instead of $conf

This looks really promising.

1. +++ b/core/lib/Drupal/Core/KeyValueStore/KeyValueExpirableFactory.php
   @@ -14,30 +14,11 @@
   -  }
   +  const DEFAULT_SERVICE = 'keyvalue.expirable.database';
   +
   +  const SPECIFIC_PREFIX = 'keyvalue_expirable_service_';
   +
   +  const DEFAULT_SETTING = 'keyvalue_expirable_default';
   +
   
   +++ b/core/lib/Drupal/Core/KeyValueStore/KeyValueFactory.php
   @@ -13,6 +14,12 @@
    
   +  const DEFAULT_SERVICE = 'keyvalue.database';
   +
   +  const SPECIFIC_PREFIX = 'keyvalue_service_';
   +
   +  const DEFAULT_SETTING = 'keyvalue_default';
   +
   

   These constants are great!
   It would be cool to document the different meaning of these different constants.

2. +++ b/core/lib/Drupal/Core/KeyValueStore/KeyValueFactory.php
   @@ -25,12 +32,17 @@ class KeyValueFactory {
    
   +  /**
   +   * @var \Drupal\Component\Utility\Settings
   +   */
   +  protected $settings;
    
      /**
       * @param \Symfony\Component\DependencyInjection\ContainerInterface $container
       */
   -  function __construct(ContainerInterface $container) {
   +  function __construct(ContainerInterface $container, Settings $settings) {
        $this->container = $container;
   +    $this->settings = $settings;
      }
   

   Some docs here and there would be cool

Let's hope it will just pass.

Patch no longer applies.

#15: 2098111_15.patch queued for re-testing.

Committed 227f21b and pushed to 8.x. Thanks!

#2100579: Add documentation to default.settings.php for override key value storage is a follow up

I personally think it is rather pointless, to inject 'settings' when we already inject the service_container anyway, out of which we could pull the settings. Is there any specific reason to do that?

Arrggh.. borked commit message.

Re-committed 714f9e3 and pushed to 8.x. This time with the correct commit message - sorry chx.

OK, that's fine by me. Just wanted to know if there's some general standard that I missed. Thanks for the answer!