Rename EntityRenderController to EntityViewBuilder

Here's the patch, let's see how good my search & replaces are.

@joachim: We discussed this issue for more than an hour. That point came up, but node_view(), user_view() and similar functions have existed since forever, so I don't think it's a problem.

Just a re-roll for now.

Fixed the left-over merge conflict in that file.

Ah, found it, nasty one. The derivate still looked for the render controller but that doesn't exist anymore to generate the entity row plugins, so they didn't exist anymore but node altered it and that resulted in an incomplete definition.

Let's see what the real remaining fails are.

Fixed a lot of tests, some pretty well hidden references to the render controller... Especially those that don't go through hasController() really should be updated. but for now, simple string replacements...

Innnteresting side effects of the entity_test changes. Will explain the changes in the next comment.

1. +++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityUriTest.php
   @@ -30,10 +30,10 @@ public function setUp() {
   -    $entity = entity_create('entity_test', array('name' => 'test', 'user_id' => 1));
   +    $entity = entity_create('entity_test_no_label', array('name' => 'test', 'user_id' => 1));
        $entity->save();
        $uri = $entity->uri();
   -    $expected_path = 'entity/entity_test/' . $entity->id();
   +    $expected_path = 'entity/entity_test_no_label/' . $entity->id();
   

   entity_test now has a uri on it's own, so we need to switch to one that doesn't.

2. +++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityViewControllerTest.php
   @@ -73,17 +73,7 @@ function testEntityViewController() {
   -    // Create a text field which will be rendered with custom item attributes.
   -    entity_create('field_entity', array(
   -      'name' => 'field_test_text',
   -      'entity_type' => 'entity_test',
   -      'type' => 'text',
   -    ))->save();
   -    entity_create('field_instance', array(
   -      'entity_type' => 'entity_test',
   -      'field_name' => 'field_test_text',
   -      'bundle' => 'entity_test',
   -    ))->save();
   +    // Make sure the test field will be rendered.
        entity_get_display('entity_test', 'entity_test', 'default')
          ->setComponent('field_test_text', array('type' => 'text_default'))
          ->save();
   

   entity_test already gets the field_test_text field by default so we don't need to create it, *but* it doesn't get the display configuration.

3. +++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityViewControllerTest.php
   @@ -111,6 +101,7 @@ public function testFieldItemAttributes() {
        // Browse to the entity and verify that the attributes from both modules
        // are rendered in the field item HTML markup.
   +    \Drupal::entityManager()->getViewBuilder('entity_test')->resetCache(array($entity->id()));
        $this->drupalGet('entity_test/' . $entity->id());
   

   entity_test apparently also has the render cache enabled, entity_render_test did not?

4. +++ b/core/modules/system/tests/modules/entity_test/entity_test.module
   @@ -527,7 +527,7 @@ function entity_test_entity_prepare_view($entity_type, array $entities, array $d
   -      if ($entity->getPropertyDefinition('field_test_text')) {
   +      if ($entity->getPropertyDefinition('field_test_text') && $displays[$entity->bundle()]->getComponent('field_test_text')) {
            foreach ($entity->get('field_test_text') as $item) {
              $item->_attributes += array('data-field-item-attr' => 'foobar');
            }
   

   This is consistent with the rdf implementation, only add the attributes if the field_test_text has a display component. Doesn't by default. One of the many problems in CommentNonNodeTest.

5. +++ b/core/modules/views/lib/Drupal/views/Tests/QueryGroupByTest.php
   @@ -24,7 +24,7 @@ class QueryGroupByTest extends ViewUnitTestBase {
   -  public static $modules = array('entity_test', 'system', 'field');
   +  public static $modules = array('entity', 'entity_test', 'system', 'field');
   

   saving an entity_test entity now results in the entity render cache getting cleared, the process of that instantiates a view builder, which in turn loads the view modes of that entity type. They are defined in entity.module.

#16: view-builder-2097903-16.patch queued for re-testing.

Re-roll.

Another re-roll and fixed a new call to getRenderController().

Fixing that test.

True, removed those two lines. The first one is from today I think and the other didn't cause any failures because the routes were defined but nothing used them.

Updated https://drupal.org/node/1819308/revisions/view/2667818/2891523.

I guess we'll create a new change notice for changing controller to something else in the main issue. I also prepared https://drupal.org/developing/api/entity to document the view builder.

Removing tags.