We found out yesterday that views_menu() re-triggers a router rebuild and various cache clears when views_menu() is called.

That's absolutely unnecessary and shaves off a few seconds of every menu rebuild.

CommentFileSizeAuthor
#4 views-invalidate-cache-2097327-4.patch1.32 KBberdir
#1 views-invalidate-cache-2097327-1.patch545 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new views-invalidate-cache-2097327-1.patch545 bytes

Here's the patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +VDC

Tagging.

Status: Needs review » Needs work

The last submitted patch, views-invalidate-cache-2097327-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new views-invalidate-cache-2097327-4.patch1.32 KB

Yes, that test needs to rebuild the router and the menu (if we don't, we get a 500 about a missing route)

Status: Needs review » Needs work
Issue tags: -Performance, -VDC

The last submitted patch, views-invalidate-cache-2097327-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +Performance, +VDC

#4: views-invalidate-cache-2097327-4.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

That was a known random fail, this is great, thanks @Berdir!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Major » Critical
Status: Reviewed & tested by the community » Fixed

Wow, GREAT find!

Committed and pushed to 8.x. Thanks!

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

I just reported #2098421: Views are rendered when drupal_flush_all_caches through RouteBuilder->rebuild()

Automatically closed -- issue fixed for 2 weeks with no activity.