We found out yesterday that views_menu() re-triggers a router rebuild and various cache clears when views_menu() is called.

That's absolutely unnecessary and shaves off a few seconds of every menu rebuild.

Files: 
CommentFileSizeAuthor
#4 views-invalidate-cache-2097327-4.patch1.32 KBBerdir
PASSED: [[SimpleTest]]: [MySQL] 58,552 pass(es). View
#1 views-invalidate-cache-2097327-1.patch545 bytesBerdir
FAILED: [[SimpleTest]]: [MySQL] 59,033 pass(es), 1 fail(s), and 0 exception(s). View

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
545 bytes
FAILED: [[SimpleTest]]: [MySQL] 59,033 pass(es), 1 fail(s), and 0 exception(s). View

Here's the patch.

jibran’s picture

Issue tags: +VDC

Tagging.

Status: Needs review » Needs work

The last submitted patch, views-invalidate-cache-2097327-1.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review
FileSize
1.32 KB
PASSED: [[SimpleTest]]: [MySQL] 58,552 pass(es). View

Yes, that test needs to rebuild the router and the menu (if we don't, we get a 500 about a missing route)

Status: Needs review » Needs work
Issue tags: -Performance, -VDC

The last submitted patch, views-invalidate-cache-2097327-4.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +Performance, +VDC
tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

That was a known random fail, this is great, thanks @Berdir!

webchick’s picture

Priority: Major » Critical
Status: Reviewed & tested by the community » Fixed

Wow, GREAT find!

Committed and pushed to 8.x. Thanks!

clemens.tolboom’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.