This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views, but it is not complete. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Figure out the missing pieces that are not yet covered. Write schema file sections for them. Clean up / fix any issues in current schema.

Create a configuration schema for entity type view_mode.

Files: 
CommentFileSizeAuthor
#3 schema_view_mode_entity-2096373-3.patch1.26 KBsushantpaste
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es). View
#1 schema_view_mode_entity-2096373-2.patch1 KBjsbalsera
PASSED: [[SimpleTest]]: [MySQL] 59,032 pass(es). View
#1 entity_view_mode_raw_data.png10.26 KBjsbalsera
#1 entity_view_mode_config_inspector_form.png26.57 KBjsbalsera

Comments

jsbalsera’s picture

Status: Active » Needs review
FileSize
26.57 KB
10.26 KB
1 KB
PASSED: [[SimpleTest]]: [MySQL] 59,032 pass(es). View

Raw data:
entity_view_mode_raw_data.png

Config editor form:

entity_view_mode_config_inspector_form.png

vijaycs85’s picture

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,27 @@
+# Configuration schema for entity type entity_display
...
+      label: 'Entity type this form or view mode is used for'
...
+      label: 'Whether or not this form or view mode has custom settings by default'
...
+      label: 'Whether or not the rendered output of this view mode is cached by default'

May need some update on comments and labels?

sushantpaste’s picture

Assigned: Unassigned » sushantpaste
Issue summary: View changes
FileSize
1.26 KB
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es). View

Updated patch with label changes.

Sumeet.Pareek’s picture

I am trying to manually review this during a contib mentoring sprint at - 2013.drupalcampdelhi.com

When I apply the patch I do get the entity.schema.yml file created in the right place, but then the manual testing steps noted here talk about comparing this file to the corresponding data.yml file, which I am not able to locate :-(

Oh btw, this is my day 1 with D8, so I am sure I would sound silly. But I have decided not to let go without manually reviewing this issue/patch like it should be *looks deteremined*

gaurav.goyal’s picture

Hey this was my first manual patch Review and was pretty much exciting,
the patch reviews are as follows : -

  1. Applied the patch using git apply and patch got applied successfully.
  2. Checked the configuration file and schema file and using (https://drupal.org/project/config_inspector), and is working correctly
sushantpaste’s picture

Status: Needs review » Reviewed & tested by the community

with reference to #5 comment changed status to RTBC.
feel free to reopen.

S.

Xano’s picture

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Great work on this, folks! :) Glad to see brand new contributors to D8 helping out!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.