Updated: Comment 0

Problem/Motivation

The PathProcessorAlias always replaced the path with an alias, even the options says on url() says that with 'alias' => TRUE.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 2096135-path-processor-alias-6.patch6.37 KBlongwave
#3 interdiff.txt540 bytesdawehner
#3 path_processor-2096135-3.patch3.76 KBdawehner
#1 path_alias-2096135-1.patch3.74 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Issue tags: +PHPUnit
StatusFileSize
new path_alias-2096135-1.patch3.74 KB

Added tag and a patch.

ParisLiakos’s picture

ParisLiakos commented

yar, extra tests for free:)

can we add some groups on the unit test really quickly?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new path_processor-2096135-3.patch3.76 KB
new interdiff.txt540 bytes

The only group which really seem to make sense is Drupal

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

As #2 is addressed so RTBC.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This actually caused a bug in rel="shortlink" URLs that do not have test coverage, I fixed it the same way but added different tests in #2087043: shortlink is not using node/nid or taxonomy/term/tid - I think we should add those tests here as well.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 2096135-path-processor-alias-6.patch6.37 KB

This is #3 plus tests from #2087043: shortlink is not using node/nid or taxonomy/term/tid, if this is committed that can be closed along with #2017087: Term shortlink link relation is broken

dawehner’s picture

dawehner
Primary language German
commented

Nice!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 144ab03 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.