Configuration translations not updated when manually importing a .po file

Trying to fix Fatal Error in #6

Thanks! This should be possible to write tests for very similarly to InstallerTranslationMultipleLanguageTest in the current codebase. Take a string like 'Anonymous' and translate it in the imported .po file. Then verify it was updated. Without this patch it should not be, with this patch it should be. Look for the .po file snippet in InstallerTranslationMultipleLanguageTest and the test snippet at the bottom. Those should suffice to prove this test works in a .po import test.

Needs work for tests.

Tagging for sprint weekend.

Removed tag by mistake.

@Gabor I've been working in the test but I'm having problems getting the translated word.
Attach a draft with the patch.

I think there are some minor problems that surely make this fail now and that will make this work :) Basically use the right source string in the .po and get() the right key from the config and you should be set. The rest are to remove extra stuff that you don't use:

1. +++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
   @@ -334,6 +334,25 @@ public function testConfigPoFile() {
   +  public function testConfigtranslationImportingPoFile() {
   

   Should have a short docblock.

2. +++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
   @@ -334,6 +334,25 @@ public function testConfigPoFile() {
   +    $language_name = 'German';
   +    $languages = array(
   +      'de' => '',
   +    );
   

   You don't use these values, no need for them.

3. +++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
   @@ -334,6 +334,25 @@ public function testConfigPoFile() {
   +    // Verify the strings from the translation files were imported.
   +    $sample = 'Anonymous user';
   

   No need for this, see below.

4. +++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
   @@ -334,6 +334,25 @@ public function testConfigPoFile() {
   +    $this->assertEqual($config->get($sample), 'Anonymous German');
   

   Well you would get('anonymous'), the key of the value not the value :)

5. +++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
   @@ -592,4 +611,22 @@ public function getPoFileWithConfig() {
   +msgid "Anonymous user"
   

   Should be "Anonymous" which is the shipped value in user.settings.yml, so it matches with the file.

Attach test.

Fixed some minor code style and typos. Otherwise looked all good :) Thanks! Blocker for #2397281: Languages not translated when you add them.

Test only patch also. Also fixing title to be more accurate.

Lol, that was a fix only, not a test only. Heh. Sorry.

The is quite an ugly fix but given the state of the helper functions in the locale module I think it is acceptable. It is fixing the bug and adds tests. Tidying up the locale is separate and bigger issue. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed c4990fc and pushed to 8.0.x. Thanks!

Indeed, the fix is ugly but that is as far as our current locale batch update API allows us to go. While it would be nice to refactor that (and batch building in general), that does not get us closer to Drupal 8 release, so we'll need to live with it for Drupal 8.