Updated: Comment #0

Problem/Motivation

In #2087231: Add a PluginBase in the Core namespace with t() as a helper method we added method t() to PluginBase. So, it's no longer needed in LocalTaskDefault

Proposed resolution

Removed the t() method and stop injecting the translation manager.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Follow-up from #2087231: Add a PluginBase in the Core namespace with t() as a helper method.

CommentFileSizeAuthor
#4 local-task-2095223-4.patch3.62 KBtim.plunkett
#4 interdiff.txt1.11 KBtim.plunkett
#1 2095223-1.patch2.51 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Priority: Major » Normal
Status: Active » Needs review
Issue tags: -Needs change record +MenuSystemRevamp, +WSCCI
StatusFileSize
new 2095223-1.patch2.51 KB

Simple patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I double checked all other plugin classes, none of them had yet added their own $this->t() yet, this was the only one.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work

Next time lets better run unit tests ...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.11 KB
new local-task-2095223-4.patch3.62 KB

Duh! @dawehner++

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

bam, lets do that.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3210323 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.