views tests that need to create views from config should just create them, not 'import' them.

over in #1808248: Add a separate module install/uninstall step to the config import process, i'm messing with the ConfigImporter, because, you know, it's the importer. it makes zero sense that changes i'm making there should blow up code over here. i can see that this 'just extend ConfigImporter' pattern prolly didn't start with views, but it must die.

#1 2095115-1-views-wtf-import.patch19.06 KBbeejeebus
PASSED: [[SimpleTest]]: [MySQL] 58,413 pass(es).
[ View ]


beejeebus’s picture

new19.06 KB
PASSED: [[SimpleTest]]: [MySQL] 58,413 pass(es).
[ View ]

aaaaand here's a patch.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Nice patch, as this really simplifies that piece of code.

jibran’s picture

Issue tags:+VDC


tim.plunkett’s picture

This pattern *totally* started with Views, and yet I agree it must die :)

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.