Background:
This issue is part of the task to update the hook_help texts of the modules for Drupal 8:
#1908570: [meta] Update or create hook_help() texts for D8 core modules

Task:
The links in hook_help need to be changed.
See https://drupal.org/node/632280#url-note

CommentFileSizeAuthor
#3 interdiff.txt2.26 KBbatigolix
#3 hook-help-editor-2091377.3.patch4.41 KBbatigolix
#1 hook-help-editor-2091377.1.patch4.41 KBbatigolix

Comments

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Needs review
StatusFileSize
new hook-help-editor-2091377.1.patch4.41 KB

patch:

- changes url() to \Drupal::url()
- changes @token to !token

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Thanks! this all looks fine. Can you fix the newline in the middle of the Installing Text Editors item too? That shouldn't be there.

Also, someone needs to manually test the links to make sure they all work and go to the right pages with this change.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new hook-help-editor-2091377.3.patch4.41 KB
new interdiff.txt2.26 KB

Patch removes newline

I tested the links (they work)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! Let's get this quick fix in.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed 
-url('admin/help/ckeditor')
+\Drupal::url('help.page', array('name' => 'ckeditor'))

Man. :( Diffs like this makes me cry a bit inside. I can confirm this is the New World Order™ though, so...

Committed and pushed to 8.x. Thanks!

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

I say this deserves a honorable mention somewhere in the D8 credits for being the smallest that went into D8. Possible?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

It is definitely not the smallest patch I've seen that got into D8 -- I'm sure at least one has just changed 1 character (spelling errors). :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.