commons_notify_commons_utility_links_alter() overwrites the $links array, removing custom links [#2090441]

What's the point of hook_commons_utility_links() when commons_notify_commons_utility_links_alter() completely removes all other alterations? I'm trying to add my own utility links but unless I change my module's weight, nothing happens.

  $new_links = array(
    'name' => $links['name'],
  );

  // ...

  $new_links['logout'] = $links['logout'];
  $new_links['settings'] = $links['settings'];

  $links = $new_links;

Comments

Comment #1

ezra-g CreditAttribution: ezra-g commented 16 September 2013 at 20:40

Title:

Commons Notify overwrites utility links

» commons_notify_commons_utility_links_alter() overwrites the $links array, removing custom links

I believe that mentions of a hook_commons_utility_links() are actually in error, and that these implementations are actually of hook_commons_utility_links_alter().

I'm trying to add my own utility links but unless I change my module's weight, nothing happens.

However, I can see how commons_notify_commons_utility_links_alter(), which overwrites $links with a $new_links array could overwrite custom links in some cases. I don't immediately see a reason why this is necessary, so retitling with the specific problem here.

Thanks for the report! If you'd like to help fix this bug, you can start by filing a patch.