Closed (fixed)
Project:
Edit
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
16 Sep 2013 at 19:02 UTC
Updated:
12 Dec 2013 at 15:40 UTC
Jump to comment: Most recent
Adding the type property:
'type' => FILTER_TYPE_MARKUP_LANGUAGE,
to commons_hashtags_filter_info's filter_hashtags make a notice go away from the edit module.
Comments
Comment #1
BarisW commentedThis it not something that should be taken of in other contrib modules. The edit module should check if 'type' isset, and if not, fallback to a default. According to the docs type is not a needed parameter.
If the maintainer of the Edit module does not want to add extra checks you can do this yourself easily using a hook_filter_info_alter.
Comment #2
kingfisher64 commentedIs this issue relevant to the following error message?
The filter "insert_view" has no type specified! This is required for the Edit module. Please consult Edit module's READMEI've read https://drupal.org/node/1817474 like the readme suggests however it's double dutch to me! :)
Could someone please instruct me as how to solve this? I know how to get rid of the errors - uninstall insert_view module however it's an essential part of the site so that's not really an option.
If it's not the same issue my apologies in advance.
Comment #3
wim leersBarisW is right: Edit extends Drupal 7 core's API in this way, so other modules should not be forced to implement this. Whenever somebody reports another filter, I implement it in Edit module's
hook_filter_info_alter().I've now implemented it for both
filter_hashtagsandinsert_view.Thanks for reporting!
http://drupalcode.org/project/edit.git/commit/c2fe8f1