Updated: Comment #0


\Drupal\search\Form\SearchSettingsForm contains a "use" statement for \Drupal\Core\Extension\ModuleHandler but that class is not used. Because it is (incorrectly) type-hinted as a member variable PhpStorm does not report it as unused.

Proposed resolution

Fix the type-hint and remove the "use" statement.

Remaining tasks

Review & commit the patch.

#1 search-settings-form-unused-module-handler.patch974 byteststoeckler
PASSED: [[SimpleTest]]: [MySQL] 59,164 pass(es).
[ View ]


tstoeckler’s picture

Status:Active» Needs review
new974 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,164 pass(es).
[ View ]

Here we go.

Berdir’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Nice catch, thanks!

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.