Updated: Comment #N
When SystemConfigFormBase was added in #1921996: Convert system_config_form() to implement FormInterface as a base class., we named it directly after system_config_form() and left it in system.module, because there was only \Drupal\Core\Form\FormInterface in that directory.
Now it can live alongside ConfirmFormBase and FormBase
Move \Drupal\system\SystemConfigFormBase to \Drupal\Core\Form\ConfigFormBase
N/A
N/A
If you extend SystemConfigFormBase, you'll have to fix your use statements.
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | config-form-base-2089627-1.patch | 22.19 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
webchickTagging.
Comment #3
jibranhappily ever after. :D
Comment #4
webchick<3 <3 <3
Committed and pushed to 8.x. Thanks!
I'll take care of the change notice.
Comment #5
webchickHooray, done. :)
Comment #6
jibranTagging.
Comment #7
jibranx-post.
Comment #8
mondrakeSeems not pushed yet?
Comment #9
mondrake@webchick sorry I do not know how else to raise this, seems like this is not pushed to HEAD... or I am missing sth
Comment #10
tim.plunkettStill applies.
Comment #11
webchickOops! So sorry. :(
Really committed and pushed to 8.x this time. :) Thanks!
Comment #12
tstoecklerAlthough this is a form, I don't see how this fundamentally belongs to the forms system. I think \Drupal\Core\Config\Form would be a much more natural fit. Thoughts?
Comment #13
tim.plunkettThat's not a namespace that exists. And we're not going to have \Drupal\Core\Confirm\Form\ConfirmFormBase or anything...
Comment #14
tstoecklerWell, OK I was a bit terse with my comment. The "Form" namespace below \Drupal\Core\Config does not exist. But the "Config" system is actually a thing, and to me it seems a thing like "ConfigFormBase" belongs to it. That was my suggestion.
There's no such thing as a "Confirm" system. That's just silly.