In a clean drupal 8 (git) installation i get "Missing text format: ." watchdog message when i go to admin/config/content/formats/manage/basic_html.

The error messages are one for each format, each time i visit admin/config/content/formats/manage/
page. I tried to save without changes, the problem remains.

My box config: Apache/2.2.22 (Unix) DAV/2 PHP/5.4.15 mod_ssl/2.2.22 OpenSSL/0.9.8x, OS X 10.7.5

CommentFileSizeAuthor
#3 2089599-3.patch919 bytesWim Leers
#2 2089599-2.patch790 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FredericoT’s picture

I did a test on a clean D8 install and noticed the same thing happening.

I looked a bit further and found that the $format_id that is being passed to the check_markup function is an empty string at the moment. Not sure what a good solution would currently be because the call to filter_fallback_format() also returns an empty string here.

swentel’s picture

Component: filter.module » editor.module
Status: Active » Needs review
FileSize
790 bytes

Could reproduce. It comes from the ckeditor module, moving to editor module component (as there's not ckeditor one)

Patch attached fixes the watchdog messages, but not sure whether this is the right solution.

Wim Leers’s picture

Component: editor.module » ckeditor.module
Priority: Normal » Minor
Issue tags: +quickfix, +Spark, +CKEditor in core
FileSize
919 bytes

Nice find!

Thanks for that patch, swentel, that really helps. See the attached reroll, which I think is better.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Works for me.

Wim Leers’s picture

Issue tags: +sprint

.

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

No test?

Wim Leers’s picture

Title: "Missing text format: ." when visiting Text formats and editors configure page » "Missing text format: ." in watchdog logs when visiting Text formats and editors configure page
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests

There's no point in writing a regression test for this. Note that the user was never affected by this, it was just a warning message in the watchdog logs!

Writing tests for this would be akin to adding tests for all possible paths in Drupal and checking if they didn't trigger a watchdog addition…

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Ok, fair enough. :)

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Issue tags: -sprint

Thanks! :)

Automatically closed -- issue fixed for 2 weeks with no activity.