#1778122-95: Enable modules to inject attributes into field formatters, so that RDF attributes get output showed that the test upgrade ends up creating an EntityDisplay object that contains data for test_deleted_field

We should make sure entity displays do not get populated with fiedls that are deleted at the time the upgrade runs.

CommentFileSizeAuthor
#3 entity_display_update-2089273-3-test-only.patch1.35 KByched
#3 entity_display_update-2089273-3.patch4.71 KByched
#3 interdiff.txt497 bytesyched
#1 entity_display_update-2089273-1-test-only.patch1.36 KByched
#1 entity_display_update-2089273-1.patch4.72 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new entity_display_update-2089273-1.patch4.72 KB
new entity_display_update-2089273-1-test-only.patch1.36 KB

Should fix it - diff is big, but this just wraps code in an if (instance is not deleted) {

Status: Needs review » Needs work

The last submitted patch, entity_display_update-2089273-1.patch, failed testing.

yched’s picture

yched commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt497 bytes
new entity_display_update-2089273-3.patch4.71 KB
new entity_display_update-2089273-3-test-only.patch1.35 KB

Silly.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Note, related, #2078505: Don't migrate deleted fields in the upgrade path

Looks good otherwise.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Just a question, does the d7-filled-db or whatever it is actually have deleted fields in it? In other words, are those added tests actually testing anything?

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Yes it does - or the test-only patch would't fail :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Duh. :P Right. :P

Committed and pushed to 8.x. Thanks! Yay better upgrade path! :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

more specific