In PHPUnit we can mock abstract classes and any methods we need, and just test the methods implemented on the abstract class.

CommentFileSizeAuthor
#5 interdiff-2088147-5.txt701 bytesdamiankloip
#5 2088147-5.patch2.24 KBdamiankloip
#1 2088147.patch2.17 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 2088147.patch2.17 KB

And a patch.

Status: Needs review » Needs work
Issue tags: -PHPUnit

The last submitted patch, 2088147.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: +PHPUnit

#1: 2088147.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented 
  1. +++ b/core/tests/Drupal/Tests/Core/Lock/LockBackendAbstractTest.php
@@ -0,0 +1,74 @@
+ * @group Drupal

    and add @group Lock as well too? 

  2. +++ b/core/tests/Drupal/Tests/Core/Lock/LockBackendAbstractTest.php
@@ -0,0 +1,74 @@
+  /**
+   * @var \Drupal\Core\Lock\LockBackendAbstract|\PHPUnit_Framework_MockObject_MockObject

    lets add the one liner doc here ;)

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2088147-5.patch2.24 KB
new interdiff-2088147-5.txt701 bytes

Great, thank you!

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work
Issue tags: -PHPUnit

The last submitted patch, 2088147-5.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: +PHPUnit

#5: 2088147-5.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

and back

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.