Remove LegacyField once all field types converted.

This is now postponed on #2015689: Convert field type to typed data plugin for options module , the last remaining issue from that meta.

Updated the OP

Unblocked. :)

Let's see if this is all there is to it.

Looks good

+++ /dev/null
@@ -1,160 +0,0 @@
-   * @see \Drupal\Core\TypedData\AllowedValuesInterface
-   */
-  public function getSettableOptions() {
-    $definition = $this->getPluginDefinition();
-    $callback = "{$definition['provider']}_options_list";
-    if (function_exists($callback)) {
-      return $callback($this->getFieldDefinition(), $this->getEntity());
-    }
-  }
-

Note: There's still a left-over implementation of this in entityreference.module, but it's already not called in HEAD anymore and there's #2160575: Option widgets integration is broken for the entity reference field to fix that. Not blocking the removal of this in any way.

+1 to RTBC.

Wooo!!!! Go go go go !!

Excellent. :)

Committed and pushed to 8.x. Thanks!

No need for a change notice since hopefully no one was using this. ;)