Once #2015689: Convert field type to typed data plugin for options module is in, we can remove:
LegacyConfigFieldItem
LegacyConfigFieldItemList
LegacyFieldTypeDiscoveryDecorator & its use in FieldTypePluginManager

CommentFileSizeAuthor
#6 2087393.patch13.71 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

Priority: Normal » Critical
catch’s picture

Issue summary: View changes
Issue tags: +beta blocker
ianthomas_uk’s picture

This is now postponed on #2015689: Convert field type to typed data plugin for options module , the last remaining issue from that meta.

yched’s picture

Issue summary: View changes

Updated the OP

webchick’s picture

Status: Postponed » Active

Unblocked. :)

amateescu’s picture

Status: Active » Needs review
FileSize
13.71 KB

Let's see if this is all there is to it.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Looks good

Berdir’s picture

+++ /dev/null
@@ -1,160 +0,0 @@
-   * @see \Drupal\Core\TypedData\AllowedValuesInterface
-   */
-  public function getSettableOptions() {
-    $definition = $this->getPluginDefinition();
-    $callback = "{$definition['provider']}_options_list";
-    if (function_exists($callback)) {
-      return $callback($this->getFieldDefinition(), $this->getEntity());
-    }
-  }
-

Note: There's still a left-over implementation of this in entityreference.module, but it's already not called in HEAD anymore and there's #2160575: Option widgets integration is broken for the entity reference field to fix that. Not blocking the removal of this in any way.

+1 to RTBC.

yched’s picture

Wooo!!!! Go go go go !!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Excellent. :)

Committed and pushed to 8.x. Thanks!

No need for a change notice since hopefully no one was using this. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.