Problem/Motivation
Now that #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations and #1851086: Replace admin/people with a View are committed, it doesn't appear that theme_exposed_filters is implemented any longer in Drupal 8.x. We can remove it.
Proposed resolution
Remove theme_exposed_filters() function and drupal_common_theme() entry.
Remaining tasks
Patch review.
User interface changes
None.
API changes
None.
Related Issues
#2006152: [meta] Don't call theme() directly anywhere outside drupal_render()
#1898480: [meta] form.inc - Convert theme_ functions to Twig
#1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations
#1851086: Replace admin/people with a View
#732914: Improve the markup/CSS for content and user filter forms
Comment | File | Size | Author |
---|---|---|---|
#8 | drupal-2087239-2.patch | 1.64 KB | ellishettinga |
#9 | drupal-2087239-8.patch | 1.62 KB | lauriii |
#1 | drupal-2087239-1.patch | 1.54 KB | c4rl |
Comments
Comment #1
c4rl CreditAttribution: c4rl commentedComment #1.0
c4rl CreditAttribution: c4rl commentedProvide relevant issues.
Comment #3
star-szrConflict with #2009674: Replace theme() with drupal_render() in system module, needs reroll.
Comment #4
ellishettinga CreditAttribution: ellishettinga commentedComment #5
ellishettinga CreditAttribution: ellishettinga commentedMoments ago I did a fresh git pull from drupal 8.x.
It seems the changes made in the patch mentioned in [#1] are no longer needed because the entries mentioned:
- theme_exposed_filters() in core/modules/system/system.module
- drupal_common_theme() in core/includes/include/theme.inc
no longer exist in 8.x core today.
I searched for the terms 'theme_exposed_filters' and 'drupal_common_theme' in core without results.
They were probably deleted in another issue.
Comment #6
star-szrI'm definitely still seeing theme_exposed_filters() in system.module… and drupal_common_theme() is for sure still there :)
Please check again, @ellishettinga. Thanks for looking at this!
Comment #7
ellishettinga CreditAttribution: ellishettinga commentedMmmm...must have done something wrong...
I will check it again !
Comment #8
ellishettinga CreditAttribution: ellishettinga commentedGit sometimes makes me angry inside (;
Patch 2 removes
- function theme_exposed_filters() from core/modules/system/system.module
- the 'exposed_filters' entry from function drupal_common_theme()
//edit: Before creating this patch it I rerolled patch #1
Comment #9
lauriiiI rerolled the patch #1
Comment #10
Xano#8: drupal-2087239-2.patch queued for re-testing.
Both patches are identical.
@lauriii, the issue was (and still is) assigned to @ellishettinga. In the future, pease take a moment to check if someone else is not already working on an issue before jumping in. This way, duplicate efforts can be prevented.
Comment #11
ellishettinga CreditAttribution: ellishettinga commentedComment #11.0
ellishettinga CreditAttribution: ellishettinga commentedUpdated issue summary.
Comment #12
parthipanramesh CreditAttribution: parthipanramesh commentedApplied patch without any issues.
Comment #13
star-szr+1, looks good.
Comment #14
catchCommitted/pushed to 8.x, needs a short change notice. Thanks!
Comment #15
ellishettinga CreditAttribution: ellishettinga commentedI'm not sure:
Does this mean we have to add an item here manually : https://drupal.org/list-changes
Or somewhere else?
I suggest this notification:
Change notice: theme_exposed_filters() removed from system.module and drupal_common_theme() removed from theme.inc
Comment #16
XanoHi @ellishettinga! Yes, change records/notices can be found there and are made manually, as not every issue needs one, or some records are for multiple issues at the same time.
Go ahead and make one for this issue, if you want to, and add a link to the record in a comment here. Good luck!
Comment #17
ellishettinga CreditAttribution: ellishettinga commentedThanks @Xano!
I created a change record for https://drupal.org/list-changes here
https://drupal.org/node/2149853
Comment #18
XanoLooks good. Thanks!
Comment #19
star-szrEdited to note that drupal_common_theme() did not get removed, thanks for creating the change notice @ellishettinga.
Comment #20
star-szrComment #21
ellishettinga CreditAttribution: ellishettinga commentedWell seen @Cottser, thanks for checking!