Problem/Motivation

Now that #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations and #1851086: Replace admin/people with a View are committed, it doesn't appear that theme_exposed_filters is implemented any longer in Drupal 8.x. We can remove it.

Proposed resolution

Remove theme_exposed_filters() function and drupal_common_theme() entry.

Remaining tasks

Patch review.

User interface changes

None.

API changes

None.

#2006152: [meta] Don't call theme() directly anywhere outside drupal_render()
#1898480: [meta] form.inc - Convert theme_ functions to Twig
#1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations
#1851086: Replace admin/people with a View
#732914: Improve the markup/CSS for content and user filter forms

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c4rl’s picture

Status: Active » Needs review
FileSize
1.54 KB
c4rl’s picture

Issue summary: View changes

Provide relevant issues.

Status: Needs review » Needs work

The last submitted patch, drupal-2087239-1.patch, failed testing.

star-szr’s picture

ellishettinga’s picture

Assigned: Unassigned » ellishettinga
ellishettinga’s picture

Status: Needs work » Needs review

Moments ago I did a fresh git pull from drupal 8.x.
It seems the changes made in the patch mentioned in [#1] are no longer needed because the entries mentioned:
- theme_exposed_filters() in core/modules/system/system.module
- drupal_common_theme() in core/includes/include/theme.inc
no longer exist in 8.x core today.
I searched for the terms 'theme_exposed_filters' and 'drupal_common_theme' in core without results.

They were probably deleted in another issue.

star-szr’s picture

Status: Needs review » Needs work

I'm definitely still seeing theme_exposed_filters() in system.module… and drupal_common_theme() is for sure still there :)

Please check again, @ellishettinga. Thanks for looking at this!

ellishettinga’s picture

Mmmm...must have done something wrong...
I will check it again !

ellishettinga’s picture

Issue tags: +Needs reroll
FileSize
1.64 KB

Git sometimes makes me angry inside (;

Patch 2 removes
- function theme_exposed_filters() from core/modules/system/system.module
- the 'exposed_filters' entry from function drupal_common_theme()

//edit: Before creating this patch it I rerolled patch #1

lauriii’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1.62 KB

I rerolled the patch #1

Xano’s picture

Issue tags: -Needs reroll

#8: drupal-2087239-2.patch queued for re-testing.

Both patches are identical.

@lauriii, the issue was (and still is) assigned to @ellishettinga. In the future, pease take a moment to check if someone else is not already working on an issue before jumping in. This way, duplicate efforts can be prevented.

ellishettinga’s picture

Assigned: ellishettinga » Unassigned
ellishettinga’s picture

Issue summary: View changes

Updated issue summary.

parthipanramesh’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Applied patch without any issues.

star-szr’s picture

+1, looks good.

catch’s picture

Title: Remove theme_exposed_filters() » Change notice: Remove theme_exposed_filters()
Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed/pushed to 8.x, needs a short change notice. Thanks!

ellishettinga’s picture

I'm not sure:
Does this mean we have to add an item here manually : https://drupal.org/list-changes
Or somewhere else?

I suggest this notification:
Change notice: theme_exposed_filters() removed from system.module and drupal_common_theme() removed from theme.inc

Xano’s picture

Hi @ellishettinga! Yes, change records/notices can be found there and are made manually, as not every issue needs one, or some records are for multiple issues at the same time.
Go ahead and make one for this issue, if you want to, and add a link to the record in a comment here. Good luck!

ellishettinga’s picture

Thanks @Xano!

I created a change record for https://drupal.org/list-changes here
https://drupal.org/node/2149853

Xano’s picture

Title: Change notice: Remove theme_exposed_filters() » Remove theme_exposed_filters()
Priority: Major » Normal
Status: Active » Fixed

Looks good. Thanks!

star-szr’s picture

Edited to note that drupal_common_theme() did not get removed, thanks for creating the change notice @ellishettinga.

star-szr’s picture

Issue tags: -Needs change record
ellishettinga’s picture

Well seen @Cottser, thanks for checking!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.