Problem/Motivation

The entity changed constraint validation was recently generalized from the node changed constraint. It was/is applied to nodes and taxonomy terms. We should apply them to blocks.

Proposed resolution

Add the proper association to the base field definition. IMHO does not need tests since the constraint itself is tested already.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

#2082509: Generalize node changed constraint to entity changed constraint

CommentFileSizeAuthor
custom-block-changed-constraint.patch1.07 KBgábor hojtsy

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Patch is trivial, any reason I should not RTBC this right away?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review

I don't have reasons against :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

NodeValidationTest tests EntityChangedConstraint, duplicating test coverage here does not make sense (see #2082509-10: Generalize node changed constraint to entity changed constraint).

The consequence is that we just need to add those few lines of metadata to get this functionality.

Hence: RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -sprint

Automatically closed -- issue fixed for 2 weeks with no activity.