The following CSS rule adds colon to every label, but this is not needed if the label is an option (radio labels i.e.).

.container-inline label:after {
   content: ':';
 }

Attached patch solves this.

CommentFileSizeAuthor
#11 drupal8-no_colon_needed_for_options_labels-2086463-11.patch487 bytesJalandhar
#3 search-block.png7.13 KBjdanthinne
#1 no-colon-for-options-labels-1.patch469 bytescr0ss
no-colon-for-options-labels.patch505 bytesjdanthinne

Comments

cr0ss’s picture

cr0ss commented
StatusFileSize
new no-colon-for-options-labels-1.patch469 bytes

An interesting situation could happen trying to use CSS2 - that simply could not work out. What do you think about adding content: ""; as a fallback for CSS2?

bserem’s picture

bserem commented

Could you please fill provide a screenshot or give guidance on where to see this behavior / steps to replicate the issue.

Thank you

jdanthinne’s picture

jdanthinne commented
StatusFileSize
new search-block.png7.13 KB

As an example, I'm currently converting my Custom Search module for D8, and when I add content types selector to the search box as radio buttons, you can see the colons…
Custom Search block

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented

1: no-colon-for-options-labels-1.patch queued for re-testing.

The last submitted patch, 1: no-colon-for-options-labels-1.patch, failed testing.

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented

no-colon-for-options-labels.patch queued for re-testing.

The last submitted patch, no-colon-for-options-labels.patch, failed testing.

droplet’s picture

droplet commented 
+++ b/core/modules/system/css/system.theme.css
@@ -111,6 +111,7 @@ abbr.form-required, abbr.tabledrag-changed, abbr.ajax-changed {
   content: none;

content:none is invalid value. Please remove it.

Sumit kumar’s picture

Sumit kumar commented

1: no-colon-for-options-labels-1.patch queued for re-testing.

droplet’s picture

droplet commented
Issue summary: View changes
Status: Needs review » Needs work
Jalandhar’s picture

Jalandhar commented
Assigned: Unassigned » Jalandhar
Status: Needs work » Needs review
StatusFileSize
new drupal8-no_colon_needed_for_options_labels-2086463-11.patch487 bytes

Updating the patch with required changes. Please review it.

Jalandhar’s picture

Jalandhar commented
Assigned: Jalandhar » Unassigned
droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

  • Commit e601933 on 8.x by alexpott: 
    Issue #2086463 by Jalandhar, cr0ss, jdanthinne: No colon needed for...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e601933 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.