#2015789: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute moved Drupal to a more modern way of handling RTL CSS.

However, not all "-rtl.css" references were removed.

This patch addresses the remainder.

remove_remaining_rtl_css_references.patch3.88 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 58,690 pass(es). View


fubhy’s picture

Status: Needs review » Reviewed & tested by the community

Did you grep for any other leftover -rtl occurrences? If so, then I guess we can RTBC this already.

Gábor Hojtsy’s picture

Issue tags: +sprint, +language-base

Agreed, looks good.

Wim Leers’s picture

#1: I did.

joelpittet’s picture

Status: Reviewed & tested by the community » Needs work

Do any of these need to be incorporated in the patch?

Searching 5583 files for "-rtl"

   75:   background: url(images/hook-rtl.png) no-repeat 0 0;

  387:   list-style-image: url(../../misc/menu-collapsed-rtl.png);

  820:   background-image: url(../images/comment-arrow-rtl.gif);

  464:   background: url(images/list-item-rtl.png) no-repeat right 11px;
 1086:   background: transparent url(images/task-item-rtl.png) no-repeat right 50%;

5 matches across 4 files

Searched for -rtl excluding vendor/* after applying the patch from the issue summary.

Gábor Hojtsy’s picture

Status: Needs work » Reviewed & tested by the community

No this issue is about removing references / uses of the old -rtl.css autodiscovery feature. Image replacements for RTL still apply.

Wim Leers’s picture

Indeed — but thanks for the double-checking! :)

joelpittet’s picture

Ok cool, RTBC +1:)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Issue tags: -sprint

Yay, thanks all!

Status: Fixed » Closed (fixed)
Issue tags: +sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Issue tags: -sprint

Superb, thanks!