Facilitates communication between Drupal and SMS gateway TurboSMS.

Links

Comments

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Vik’s picture

StatusFileSize
new18.04 KB
pgautam’s picture

Priority:Normal» Critical
Status:Needs review» Needs work

Hi Vik,

Please put it in the git repository and provide public link for download.

Thanks,
Paritosh Gautam

Vik’s picture

Issue summary:View changes

Add "git clone --branch master http://git.drupal.org/sandbox/Vik/1993102.git turbosms"

Vik’s picture

Priority:Critical» Normal

Hi Paritosh Gautam,

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Vik/1993102.git turbosms

Thanks, Vitaliy Sytnik

pgautam’s picture

StatusFileSize
new44.1 KB
new56.4 KB

Hi,

Please find attached ventral comments please fix these in priority.

Thanks,
Paritosh Gautam

Vik’s picture

Can be false operation?

<?php
   
...
   
$id_unsended = 0;
   
$id_delete = array();
    foreach (
$id as $key => $value) {
      foreach (
$value as $k => $v) { // line 79
       
if ($v == 'UNSENDED') {
          ++
$id_unsended;
         
array_push($id_delete, $key);
        }
      }
    }
   
$id_delete = array_flip($id_delete);
   
$id = array_diff_key($id, $id_delete);
    ...
?>

FILE: /var/www/drupal-7-pareview/pareview_temp/turbosms.admin.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
79 | WARNING | Unused variable $k.
--------------------------------------------------------------------------------

Vik’s picture

Status:Needs work» Closed (fixed)

In the git repository and provide public link for download.

Vik’s picture

Status:Closed (fixed)» Active
Vik’s picture

Status:Active» Needs review
davidmac’s picture

Hi,

It seems as if you've put a lot of work into this module. I have just one or two suggestions.

You've inserted TurboSMS as it's own 'Package' in your .info file, but packages are really categories such as 'Search', 'Development' etc.
Unless you have sub-modules, its worth considering if this falls into another category following the guidelines.
https://drupal.org/node/542202
https://groups.drupal.org/node/97054

On first load, the module throws up several errors:
Notice: Undefined index: turbosms in turbosms_admin_gateway() (line 17 of /var/www/devdavid/sites/all/modules/mysite/turbosms/turbosms.admin.inc).
Have you looked at these?

There is no hook_help() and there is no path to the configuration options in your .info file. And the project page is thin, as is the documentation:
https://drupal.org/node/7765

Jay.Chen’s picture

Assigned:Vik» Unassigned
Status:Needs review» Needs work

1. Should use placeholder in t function. e.g.
t('Id messages : ') . $node->sid should be changed to t('Id messages : !sid', array('!sid' => $node->sid)).
If you want to encode string, you should use t('Id messages : @sid', array('@sid' => $node->sid))

2. Line 342, should change 'Submit' to t('Submit').

3. Lines 240 and 241, you should use t function to wrap the string.

Jay.Chen’s picture

Issue summary:View changes

move "master -> 7.x-1.x"

PA robot’s picture

Issue summary:View changes
Status:Needs work» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.