Remove plugin.manager.entity service in favor of entity.manager

Every other plugin follows the plugin.manager.* format, so I don't think removing it makes sense.

Maybe just and some docs about suggested service name to use somewhere?

I don't want to seem like an old record, but entity types are not plugins :-)
So +1 on this.

There we go.

forum was lost

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/AggregatorCategorizeFormBase.php
@@ -79,11 +79,12 @@ public function __construct(EntityRenderControllerInterface $aggregator_item_ren
   public static function create(ContainerInterface $container) {
+    $entity_manager = $container->get('entity.manager');
...
-      $container->get('plugin.manager.entity')->getRenderController('aggregator_item'),
+      $entity_manager->getRenderController('aggregator_item'),
...
-      $container->get('plugin.manager.entity')->getStorageController('aggregator_item')
+      $entity_manager->getStorageController('aggregator_item')

This change unnesesary

#7: entity_manager-2084279-7.patch queued for re-testing.

Rerolling this should be pretty easy.

Re-rolled

replace some new cases.

reroll + update.

Perfect! I could not find any other usage of the service.

18: entity_manager-2084279-18.patch queued for re-testing.

Re-roll.

Re-RTBC

22: drupal_2084279_22.patch queued for re-testing.

rerolled

It is green!

OK, let's add that tag and get this sucker in :-)

(not sure why this has the "Needs committer feedback" though ?)

Committed/pushed to 8.x, needs short change notice. We should have done this in the first place (rip the old manager out) since it's very confusing having a duplicate service.

spelling++

Tagging to write up the change record.

https://drupal.org/node/2084279

I think that's a link to this issue rather than to a change record!

Oh I am sorry I was quite sure when I went to the other issue that jibran linked to the issue as a change notice. Sorry.

adding change record tag back.

And active.

Assigning to myself to create change notice.

Created change notice: https://drupal.org/node/2181815

Thanks @lexfunk!