Unit test for the Drupal\serialization\Normalizer\ListNormalizer class.

CommentFileSizeAuthor
#3 interdiff-2083983-3.txt746 bytesdamiankloip
#3 2083983-3.patch4.92 KBdamiankloip
d8.XmlEncoderTest.patch4.84 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented 
  1. index 1f25389..3b19a44 100644
--- a/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php

--- a/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php
+++ b/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php

    Any reason to keep the code in the constructor? 

  2. +++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Encoder/XmlEncoderTest.php
@@ -0,0 +1,103 @@
+/**
+ *
+ */

    That is pure nihilism. 

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Encoder/XmlEncoderTest.php
@@ -0,0 +1,103 @@
+  }
+
+
+}

A bits too much whitespace.

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2083983-3.patch4.92 KB
new interdiff-2083983-3.txt746 bytes

Thanks for the review! I've made those changes, except...

Any reason to keep the code in the constructor?

I think it's just a confusing diff, because the constructor has been completely removed :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Ha!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 29dd37a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.