SearchExcerpt test has a small problem [#2083773]

Over on #1970588: SearchExcerptTestCase should be a DrupalWebTestCase Heine apparently found and patched an unrelated bug in the SearchExcerpt test D7 version:

     $longtext = str_repeat($text . ' ', 10);
-    $result = preg_replace('| +|', ' ', search_excerpt('nothing', $text));
+    $result = preg_replace('| +|', ' ', search_excerpt('nothing', $longtext));
     $this->assertTrue(strpos($result, $expected) === 0, 'When keyword is not found in long string, return value starts as expected');

This fix needs to get into Drupal 8 and then be backported to D7. I'm moving it to a new issue. Can someone make a quick patch please?

Comment	File	Size	Author
#6	drupal_core-search_test_error-2083773-6.patch	919 bytes	Pete B
#6

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

littledynamo CreditAttribution: littledynamo commented 9 September 2013 at 19:05

Assigned:

Unassigned

» littledynamo

Got a code sprint planned next week, so we'll take care of this one.

Comment #2

littledynamo CreditAttribution: littledynamo commented 9 September 2013 at 19:24

Issue tags:

-Novice

Comment #3

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 9 September 2013 at 20:05

Issue tags:

+Novice

Let's leave the Novice tag on. Many times it happens that someone assigns an issue to themselves and never actually follows through to finish it, and at least this way if you do (not that I think you will, but just in case), the issue will probably be picked up later by a different contributor. You have already claimed the issue and commented that you plan to make a patch next week, so no one else should step in and do it before then.

Thanks!