For instance, Tim creates a group called "Top team" and makes the Privacy setting 'Joining requires an invitation.' Tim then adds the post "Stuff" to the "Top team" group.
Roger, a member of "Anytown" and "Sandbox" groups (but not "Top team") logs in and can see "Stuff" on the home page and "Top team" in the groups list.
I would expect both the group and any content in the group to be hidden from non-members (checking the membership for "Top team" just shows, as expected, Tim as the administrator). This isn't the case.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | commons-private_content_invitation-2083261-12.patch | 1.93 KB | heddn |
Comments
Comment #1
ezra-g commentedIt sounds like you haven't configured your group privacy settings correctly.
Can you confirm that you have:
1) Enabled OG_Access module
2) Rebuilt the node access permissions
3) Set the group privacy settings to "Joining requires an invitation. The group and content is hidden from non-members."
4) Saved any content in the private group following step 3
Comment #2
japerryI cannot replicate. Can you confirm that og_access is enabled?
Comment #3
japerrygah sorry Ez
Comment #4
ezra-g commentedCrosspost.
Comment #5
ezra-g commented@garyconroy, please do let us know if you're able to reproduce this problem with the steps in #1, or with the "Hide contributed content from non-members" option checked.
I'm retitling the issue as a proposal to clarify the text on the group privacy settings for sites where OG Access module is disabled.
Currently, the text for the 3rd group privacy settings radio button reads:
With OG Access disabled:
"Joining requires an invitation."
With OG Access enabled:
"Joining requires an invitation. The group and content is hidden from non-members."
Proposed change to text with OG Access enabled:
"Joining requires an invitation. The group and content is visible to non-members"
Comment #6
ezra-g commentedAdding to the 3.4 radar.
Comment #7
garyconroy commentedConfirming that ezra-g's steps fixed the issue.
Comment #8
ezra-g commentedAnother way of presenting these settings would be in terms such as:
Members can:
non-members can:
Any site member can:
Comment #9
topham commentedI've been working with Drupal Commons 3.3 for a couple of days and I've enabled Organic Groups Access module, yet I don't see that setting.
However, when I click "Joining requires admin approval" I do see the checkbox appear for "Hide contributed content from non-members"
It looks to me like the text for both is configured based on the "og_access" module being enabled, so I don't understand why I would see one, and not the other.
I found it very confusing to be looking at the screen initially, without "Organic groups access control" enabled there was no obvious place to configure Groups to be secured at all. I realize not everybody wants this functionality, but a note like "To enable greater group permissions, or exclude non-members you must enable the "Organic groups access control" module" would have greatly simplified the situation.
Comment #10
WebSinPat commented+1 for the steps in #1 working for me
+1 for @ezra-g's suggestions of clarifying the language
+1 for @topham's suggestion of clarifying the existence and howto of og_access, if it is not to be enabled by default.
Comment #11
heyyo commentedI still have this issue even after following #1.
It was working correctly, untill I deleted my groups and recreated them.
In my group permissions "Contribute to the group" is checked for non-members.
Comment #12
heddnRe-titling to better describe the issue.
Here's the reason why things seem broken. Marking something as "Invitation only" doesn't provide access to the field_og_access_default_value field. Which means that when commons_groups_node_presave() processes the node, it doesn't think the field should be marked as private. The attached patch should clean things up.
Comment #13
heddnJust noticed, this should really be a bug, not a task. The description for invitation indicates that all content should be private if you choose it. So it doesn't live up to its intention.