Unit test for the Drupal\serialization\Normalizer\ListNormalizer class.

Related to #2082735: Unit test Drupal\serialization\Normalizer\TypedDataNormalizer class

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

linclark’s picture

Status: Closed (fixed) » Needs work
+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Normalizer/ListNormalizerTest.phpundefined
@@ -0,0 +1,105 @@
+
+  /**
+   * The TypedDataNormalizer instance.
+   *
+   * @var \Drupal\serialization\Normalizer\TypedDataNormalizer
+   */
+  protected $normalizer;

It looks like there are some copy/paste issues with this test.

linclark’s picture

Also, it would be nice to have some comments in the setUp().

damiankloip’s picture

Status: Needs work » Needs review
FileSize
1.46 KB
linclark’s picture

Should the @group be Drupal? It looked like it was specific to the package in other tests.

linclark’s picture

Also, the getInfo method needs to be switched from TypedData to List.

dawehner’s picture

Should the @group be Drupal? It looked like it was specific to the package in other tests.

Yeah this would be great to add.

linclark’s picture

Status: Needs review » Needs work
damiankloip’s picture

Status: Needs work » Needs review
FileSize
982 bytes
1.88 KB

Fair, how about...

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

I should have reviewed it with more clarity.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.