Reset to defaults should call entity's update hooks

I'd like to get merlinofchaos' opinion on this.

Lets get the patch reviewed.

Rerolled because of #2218275: 'Reset' should not delete all {panelizer_entity} records for the entity.

Strictly speaking this then means that the caches don't have to be manually purged.

8: panelizer-n2082841-8.patch queued for re-testing.

Is there more steps to reproduce, test this? I ran through xdebug and could never get page_reset to run, which leads to executing $this->reset_entity_panelizer($entity, $view_mode);.

However, I did xdebug on Entity Cache and entitycache_entity_update() seems to get called whenever Panelizer settings (custom settings, content, etc) are updated.

Rerolled.

FYI I also created #2409373: "Reset to defaults" should work with revisions as I realized that revisions were not being handled correctly.

Again, I think this is working as expected. This patch is within delete_entity_panelizer() method.

  public function hook_entity_delete($entity) {
    $this->delete_entity_panelizer($entity);
  }

I tried to find usages of this method, and this is the only time it is used - the hook_entity_delete() method. It doesn't seem to hurt anything by trying to save the entity, however resetting caches seems less harmful then attempting to save the entity.

Resetting a view mode invokes reset_entity_panelizer().

    // Only proceed if the view mode was customized for this entity.
    if (empty($entity->panelizer[$view_mode])) {
      drupal_set_message(t('Unable to reset this view mode'));
    }
    else {
      // Identify this entity's bundle.
      list($entity_id, , $bundle) = entity_extract_ids($this->entity_type, $entity);

      // Update the panelizer_entity record.
      $entity->panelizer[$view_mode]->did = NULL;
      $entity->panelizer[$view_mode]->name = $this->get_default_display_name($bundle, $view_mode);

      // Update the entity.
      $this->entity_save($entity);

And this does invoke an entity save. Both methods delete items from the panelizer_entity table and remove entries. Except the reset is working as designed, and as requested in the issue.

Should it also remove the $entity->panelizer records?

This caused smart_ip module not to work. With this patch enabled going to admin/config/people/smart_ip caused WSOD and a segmentation fault. https://www.drupal.org/node/2798325

this was on a clean install