Shortcut add/remove link on titles don't work on route only pages

Can you list some example pages where this can be verified? Looking at a local install it seems like all are working in Severn and none in Bartik.

• Re-rolled to keep up with head.
• Removed the "p"-prefix from other shortcut tests (debugging artifact).
• Changed assertFalse(!empty()) to assertTrue(empty()) for legibility.

+++ b/core/modules/shortcut/shortcut.module
@@ -373,7 +374,21 @@ function shortcut_preprocess_page(&$variables) {
+    // @todo What should be done on a 404/403 page?
+    $item['access'] = TRUE;

This seems like a problem still.

Current behaviour is the same as it is in Drupal 7.x: the "Add to shortcuts" icon/link is shown on access denied, but not on page not found.

It does not make sense to display the icon/link on a 403 page, but this patch does not alter the current behaviour, so I think it is best to tackle this in a separate issue (especially since determining whether or not the page is a 403/404 in shortcut_preprocess_page() seems non-trivial according to #1969270: 403/404 pages: drupal_get_http_header('Status') returns no status code at all)?

Really marking as critical :)

+++ b/core/modules/shortcut/shortcut.module
@@ -373,7 +374,21 @@ function shortcut_preprocess_page(&$variables) {
+  if ($request->attributes->has('_legacy')) {
+    // @todo Remove once the old router system got removed.
+    $item = menu_get_item();
+  }

Do we really still need this?

I can't see _legacy being set anywhere so it does look superflous.

"_legacy" was removed in #2106709: Remove legacy router backward compatibility layer

Rerolled without _legacy-support.

Thanks, thought so, back to RTBC then.

1. +++ b/core/modules/shortcut/shortcut.module
   @@ -388,7 +389,17 @@ function shortcut_preprocess_page(&$variables) {
   +  if ($route = $request->attributes->get(RouteObjectInterface::ROUTE_NAME)) {
   

   /me shudders but already did that on #2095959: Remove instances of menu_get_object('node'), not the fault of this patch.

2. +++ b/core/modules/shortcut/shortcut.module
   @@ -388,7 +389,17 @@ function shortcut_preprocess_page(&$variables) {
   +  if (shortcut_set_edit_access() && ($item) && $item['access']) {
   

   Very nitpicky but why not just !empty($item['access'])?

1. will be addressed as part of #2124749: [meta] Stop using $request->attributes->get(MAGIC_KEY) as a public API
2. Fixed

new patch attached.

Yes, looks better, RTBC unless testbot disagrees (he better not! ;))

15: 2081963-15-shortcut-route-only-pages.patch queued for re-testing.

15: 2081963-15-shortcut-route-only-pages.patch queued for re-testing.

Passed testing, so back to RTBC

Committed/pushed to 8.x, thanks!