Updated: Comment #0

Problem/Motivation

In #2058321: Move the 'place block' UI into the block listing I used "left" and "right" to divide the block list form into columns, that should have been "primary" and "secondary".
Furthermore, I made the change at the Form API level, making needless changes to the form structure.

Proposed resolution

Revert the Form API changes and use a template file

Remaining tasks

N/A

User interface changes

N/A

API changes

The form structure will be back as it was, so this reverts a minor API change.

#2078601: Move the block placement browser to the left of table and collapse it

CommentFileSizeAuthor
#1 block-2079761-1.patch12.57 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new block-2079761-1.patch12.57 KB

I split this out of #2078601: Move the block placement browser to the left of table and collapse it because that issue doesn't have consensus.
In the meantime, this blocks all of the other patches I have that try to change the block form.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This looks pretty great to me, big improvement IMO. The repetition of .layout-region is not ideal but there is #2061863: Make two column node CSS reusable to resolve that.

tkoleary’s picture

tkoleary commented

@tim.plunkett

Looks awesome!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned

Automatically closed -- issue fixed for 2 weeks with no activity.