Follow-up from #1497374: Switch from Field-based storage to Entity-based storage.

There's some code left that is no longer used, let's remove it.

CommentFileSizeAuthor
#4 field_storage_cleanup-2079025-4.patch26.76 KByched
#2 field_test_storage-2079025-1.patch14.49 KByched

Comments

yched’s picture

yched commented

Damn, I forgot about those, we could have reached 700k in the storage patch :)

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new field_test_storage-2079025-1.patch14.49 KB

This was a test implementation for the "field storage backend API", which has been removed.
#1497374: Switch from Field-based storage to Entity-based storage already removed the line that loaded that include file.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

That wouldn't have been enough for 700kb ;)

But there's some more, so we still have a chance.

Search for "field_storage", for example:

- Some mentions and hook documentations in field.api.inc
- @defgroup field in field.module (I guess that will need more work to update to 8.x, can't imagine that still being up to date, but separate issue and easier when everything complete I guess)
- field_help() has a link related to it, might need a new documentation page?
- @defgroup field_purge in field.purge.inc
- docblock of FieldAttachStorageTest

yched’s picture

yched commented
Status: Needs work » Needs review
StatusFileSize
new field_storage_cleanup-2079025-4.patch26.76 KB

Gee, there's some seriously outdated doc here...

Not exactly sure what should happen with FieldAttachStorageTest, actually. This is at least mostly testing behavior of the the storage controllers now, but sorting this out exactly is not fully trivial :-/. Opened #2079543: Figure out the fate of FieldAttachStorageTest.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed 
7 files changed, 38 insertions, 559 deletions.

Nice.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.