#1987602: Convert ajax_form_callback() to a new style controller accidentally introduced a "route name" in hook menu, which should be "route_name".

However, as stated in #3, the item isn't even necessary at all, so we will remove it.

CommentFileSizeAuthor
#4 2078885_remove_file_progress_hook_menu_item_4.patch491 bytesLetharion
#1 2078885-use_underscore_in_route_name_1.patch461 bytesLetharion

Comments

Letharion’s picture

Letharion commented
StatusFileSize
new 2078885-use_underscore_in_route_name_1.patch461 bytes
dawehner’s picture

dawehner
Primary language German
commented

Is there any way how we can test that?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

The code on the controller does not deal with the theme system at all, as it just returns as json response
so we don't need the entry at all.

Letharion’s picture

Letharion commented
Title: File uses "route name" instead of "route_name". » The file/progress hook menu item is not necessary.
StatusFileSize
new 2078885_remove_file_progress_hook_menu_item_4.patch491 bytes
Letharion’s picture

Letharion commented
Status: Needs work » Needs review

Issue summary updated. Patch up for review.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

That is perfect!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Took me a minute, but basically because this is a MENU_CALLBACK, we don't need a menu item here. The route's already defined in file.routing.yml.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated summary up until #3.