Allow local task plugins on paths with a dynamic value (like a node)

Here's a new version that takes the route parameters from the Request.

A couple of those look like sporadic fails (don't et a fail locally for PageNotFoundTest) and the LocalTasksTest is actually looking for the active class on the wrong element - the A instead of the LI.

So, this has been a bogus test for a while. however, the change to the link generator should not have affected that.

This patch adds comment local tasks - though really we want the YAML implementation in so we don't have to re-convert them.

Bug opened here: #2084125: Bug in active detection in LinkGenerator - need to extract array from _raw_variables ParameterBag

I'm not sure this is correct or needed?

+      elseif ($request->attributes->has($name)) {

The ParamConverterManager puts the raw values of all the route variables into _raw_variables regardless of whether or not they are later upcast.

Improve code comments including an actual route and less ambiguous example

Fixes local fails for me by removing the weights on the test plugins (by default the root one gets -10)

Also, remove unused use statements.

#24: local_task-2076283-24.patch queued for re-testing.

Needs to be re-rolled for #2050919: Replace local task plugin discovery with YamlDiscovery

issue tag weirdness...

and more such

working on the re-roll now...

Since files are renamed, etc I don't think an interdiff is meaningful here. BAsically the same as #24 with conversion to YAML files.

loving this. Think there might be a bug in trailing parameters though. Working on a test case.

Rerolled after routing key rename and with tests for the bug I'd found and a fix from dawehner. Will need another reroll shortly for the pattern->path change but want get this up and out of the way.

reroll after #2053489: Standardize on \Drupal throughout core and space fix.

oh right, and pattern change.

Great work with the added test coverage and use cases.

+++ b/core/lib/Drupal/Core/Menu/LocalTaskDefault.php
@@ -91,26 +92,43 @@ public function getRouteName() {
-  public function getTitle() {
-    // Subclasses may pull in the request or specific attributes as parameters.
-    return $this->t($this->pluginDefinition['title']);
...
+  public function getTitle() {
+    // Subclasses may pull in the request or specific attributes as parameters.
+    return $this->t($this->pluginDefinition['title']);

This is the only part of the patch I thought was questionable, but it isn't added here, just moved. +1 for RTBC

just a reroll to fix a conflict. no changes.

Yes this looks good. Committed/pushed to 8.x.

Will need a change notice.

Here's a short change notice: https://drupal.org/node/2094027

Re-opening this for the following problem:

+++ b/core/includes/menu.inc
@@ -1979,6 +1986,20 @@ function menu_local_tasks($level = 0) {
+      foreach ($local_tasks as $level => $items) {

This is overriding the $level variable that is being passed into the function. I'm not 100% through with debugging, but I think this might be the cause of some missing tabs in config_translation that I'm having a problem with.

Here we go. The tab funkiness I experienced was in fact not related to this at all. I still think this should be fixed, though. I'm fine with moving this into a follow-up, but I wanted to get some attention from some people who understand what's going on here, first.

Let's move this to a follow-up, since this issue was marked closed/fixed.

Looks indeed like ti would be better not to whack the variable.