jQuery Once 1.2.3 comes with a few things:

  1. CommonJS/UMD support
  2. Testing with QUnit
  3. Automated testing with qunit/grunt/phantom/etc
  4. Built via grunt
  5. JSHint validated
  6. Available through Composer, component, bower, jQuery Plugins, etc

This doesn't give Drupal anything special out of the box, it's just a small update that improves the internals of jQuery Once.

CommentFileSizeAuthor
#4 2075199.patch2.33 KBrobloach
jqueryonce123.patch1.72 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Issue summary: View changes

Updated issue summary.

robloach’s picture

robloach
he/him
commented
Issue summary: View changes

Updated issue summary.

robloach’s picture

robloach
he/him
commented
Issue summary: View changes

Updated issue summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

good to go. thanks.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs manual testing

We don't have automated JS testing so anytime we do a lib update like this we need someone to do some clicking and report back.

Here are some places that use it:

./core/modules/ckeditor/ckeditor.module:      array('system', 'jquery.once'),
./core/modules/ckeditor/ckeditor.module:      array('system', 'jquery.once'),
./core/modules/ckeditor/ckeditor.module:      array('system', 'jquery.once'),
./core/modules/color/color.module:      array('system', 'jquery.once'),
./core/modules/color/color.module:      array('system', 'jquery.once'),
./core/modules/content_translation/content_translation.module:      array('system', 'jquery.once'),
./core/modules/contextual/contextual.module:      array('system', 'jquery.once'),
./core/modules/contextual/contextual.module:      array('system', 'jquery.once'),
./core/modules/editor/editor.module:      array('system', 'jquery.once'),
./core/modules/field_ui/field_ui.module:      array('system', 'jquery.once'),
./core/modules/filter/filter.module:      array('system', 'jquery.once'),
./core/modules/filter/filter.module:      array('system', 'jquery.once'),
./core/modules/filter/filter.module:      array('system', 'jquery.once'),
./core/modules/language/language.module:      array('system', 'jquery.once'),
./core/modules/locale/locale.module:      array('system', 'jquery.once'),
./core/modules/overlay/overlay.module:      array('system', 'jquery.once'),
./core/modules/simpletest/simpletest.module:      array('system', 'jquery.once'),

Doesn't need to be all of them, but let's make sure it's at least a few of them.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review

not that.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing
StatusFileSize
new 2075199.patch2.33 KB

Tested ckeditor, filter, editor, modules page, etc.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Please don't upload different patches without an interdiff then RTBC them.

robloach’s picture

robloach
he/him
commented

Here's what's was added in the follow up patch. The update to system module's definition of jquery.once:

+++ b/core/assets/vendor/jquery-once/jquery.once.jsundefined
@@ -76,4 +89,4 @@
diff --git a/core/modules/system/system.module b/core/modules/system/system.module
index bd58f93..c561c5d 100644
--- a/core/modules/system/system.module
+++ b/core/modules/system/system.moduleundefined
@@ -1251,8 +1251,8 @@ function system_library_info() {
   // jQuery Once.
   $libraries['jquery.once'] = array(
     'title' => 'jQuery Once',
-    'website' => 'http://plugins.jquery.com/project/once',
-    'version' => '1.2',
+    'website' => 'http://plugins.jquery.com/once/',
+    'version' => '1.2.3',
     'js' => array(
       'core/assets/vendor/jquery-once/jquery.once.js' => array('group' => JS_LIBRARY, 'weight' => -19),
nod_’s picture

nod_
Primary language French
Location Lille
commented

Meh missed that, I get sloppy with RTBC on holidays. Thanks Rob.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

OK that makes sense.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Cool, thanks.

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.