Favicon has a square white background. It would look a lot better with a transparent background. I am unsure about how to patch this properly, so have attached fixed file here (only change is to make white transparent on both layers).
File to be patched is located at profiles/commons/themes/commons/commons_origins
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | use-transparent-favicon-2074179-3.patch | 4.24 KB | devin carlson |
| #3 | favicon_comparison.png | 17.34 KB | devin carlson |
| #1 | favicon.ico_.tar_.gz | 1.45 KB | Rustan |
Comments
Comment #1
Rustan commentedUncompressed favicon was not accepted. Uploading again, compressed version.
Comment #2
ezra-g commentedThanks! Adding to our 3.4 radar.
Comment #3
devin carlson commented+1 to a transparent background for the favicon.
The attached patch updates the favicon to use the image from #1.
And a comparison of the favicon with the white vs. transparent background:
Comment #4
japerryLooks good to me! FYI it can be annoying to clear cache in firefox, so try out the patch in a different browser to verify it works.
Comment #5
japerryFixed!
http://drupalcode.org/project/commons.git/commit/8af1883
Comment #7
adminaliz commentedHey,
Just a newbie here trying to get a test site up. My ISP has supplied me with 7.34. My flavicon still has a white background even though it is transparent in my editor. Was this fix applied to 7.34 already and if not, how do I apply it? Where do I get the fix file from?
Thanks,
Bob.