In menu_enable db_query is called twice, with the result of the latter query overwriting the result of the former one.
Guess this makes no sense.

CommentFileSizeAuthor
#3 q.patch539 byteschx
menu_enable.patch747 bytespancho

Comments

pwolanin’s picture

pwolanin commented

You're right -there is no reason to run that query twice. However, I might delete the 1st rather than the 2nd query, since hte second one would then be right before the loop that uses it.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

Well, I thought about that, too. But I guess it'd be better to initialize the variables in the order they are called in the while clause...

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new q.patch539 bytes

Agreed with pwolanin.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Indeed, looks good, committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.