I think this module has a great potential. Some minor improvements can make it better. For example:

- Alhtough i define a body title, the body doesn't show up in the smackdown creation page.
- Dropdown list of content types displays machine-readable type names rather than human readable type labels.
- Ability to select the content fields to be displayed in smackdown. For example, when comparing movies, only posters (image fields) should be displayed.

CommentFileSizeAuthor
#6 smackdown_body_207346.diff1008 bytessirkitree
#2 smackdown_human-readable-content-type_207346.diff664 bytessirkitree

Comments

sirkitree’s picture

sirkitree commented
Assigned: Unassigned » sirkitree

This content type, being defined by hook_node_info() and then manipulated with hook_form(), has the title automatically set to the first node reference's title 'vs.' the second node reference's title in hook_submit(). I'm open to suggestion on how to deal with this better.

I like the idea of content types giving the human readable labels and will implement.

Your third feature request sounds great too, but I'm not sure how to implement this either. Currently you can do this on the theme layer once you go to theme the node.

sirkitree’s picture

sirkitree commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new smackdown_human-readable-content-type_207346.diff664 bytes

Here's the patch for putting in human readable labels for the content type dropdown.

drupaloSa’s picture

drupaloSa commented

Thanks for the quick patch.

This content type, being defined by hook_node_info() and then manipulated with hook_form(), has the title automatically set to the first node reference's title 'vs.' the second node reference's title in hook_submit(). I'm open to suggestion on how to deal with this better.

Sorry, i don't understand much about this "hook" issue, but i suppose you're saying that the content body won't be displayed whether or not i disable it, right?

Your third feature request sounds great too, but I'm not sure how to implement this either. Currently you can do this on the theme layer once you go to theme the node.

Do you mean the contemplate module?

sirkitree’s picture

sirkitree commented

Maybe I'm misunderstanding what you're trying to do here. Can you please elaborate what you mean by content body? Are you trying to add cck fields to the smackdown content type?

As for the theme layer, I was referring to contemplate module, per say... but you could use that to manipulate it, yes.

drupaloSa’s picture

drupaloSa commented

When you go to admin->content types->smackdown, you'll see

Body
[***Textbox***]
To omit the body field for this content type, remove any text and leave this field blank.

Here i write "body" or "description" to the textbox. But when creating a smackdown, body field doesn't appear.

sirkitree’s picture

sirkitree commented
StatusFileSize
new smackdown_body_207346.diff1008 bytes

Oh ok.

I didn't envision a need for the body for this.

Here's a patch that will add it in.

drupaloSa’s picture

drupaloSa commented

Thanks again :)

sirkitree’s picture

sirkitree commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.