Problem/Motivation

The following scenario occurred on http://tour.drutch.nl/admin/config/user-interface/tour

There are 2 tours bound to <front>

- tour.tour.toolbar (module: toolbar)
- tour.tour.tour-integration (module: tour_builder)

The site builder must be able to disable tours.

Proposed resolution

Operations are now available but core does not react.

Remaining tasks

Review patch
Add tests to core #3004897: Respect tour status (disabled | enabled)

User interface changes

API changes

- Core
- #3004897: Respect tour status (disabled | enabled)
- Outdated #2074835: Tour: make operations enable | disable available for tours

CommentFileSizeAuthor
#12 Screenshot 2022-10-27 at 12.31.00.png10.93 KBclemens.tolboom
#11 2073321-11.patch4.79 KBsmustgrave
#11 interdiff-3-11.txt3.95 KBsmustgrave
#3 tour_ui-2073321-3.patch3.98 KBclemens.tolboom
#2 we_need_to_disable-2073321-1.patch1.53 KBclemens.tolboom

Issue fork tour_ui-2073321

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes

Added issue summary template

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes

typo

nick_schuch’s picture

nick_schuch commented
Version: » 8.x-1.x-dev

The parent class provides these. I commented them out at the time as I was focusing on tip manipulation.

+1 to this

nick_schuch’s picture

nick_schuch commented
Issue summary: View changes

Updated issue summary.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new we_need_to_disable-2073321-1.patch1.53 KB

The operations Enable and Disable do not exists in Core Tour

Attached patch is first stab. It still needs the confirm forms.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
StatusFileSize
new tour_ui-2073321-3.patch3.98 KB

I can change the status of a tour but code tour is not responding to a disabled status.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Parent issue: » #3004897: Respect tour status (disabled | enabled)
Related issues: +#2074835: Tour: make operations enable | disable available for tours

Issue #2074835: Tour: make operations enable | disable available for tours is out dated as operation for config entities are now available.

Core issue #3004897: Respect tour status (disabled | enabled) fixes this.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes
Related issues: -#2074835: Tour: make operations enable | disable available for tours
smustgrave’s picture

smustgrave commented
Status: Needs review » Closed (outdated)

Going to close this since a core ticket is already open.

smustgrave’s picture

smustgrave commented
Status: Closed (outdated) » Active

Oops see this patch is needed to go with the core one.

smustgrave’s picture

smustgrave commented

So tested patch #3 and see that the option to disable is in the dropdown but when I go into the tour I cannot disable from there.

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
StatusFileSize
new interdiff-3-11.txt3.95 KB
new 2073321-11.patch4.79 KB

The core issue is in review.

Fixed the issue I brought up in #10

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
StatusFileSize
new Screenshot 2022-10-27 at 12.31.00.png10.93 KB

LGTM so we have to wait on #3004897: Respect tour status (disabled | enabled)

I tried to put enable/disable above 'delete' but failed to do. Even

    $operations['edit']['weight'] = 10;
    $operations['delete']['weight'] = 10;

did not help. Is this a core bug we should file an issue with?

As we get Edit/Delete from parent guess we do not need to redefine them? (No need to put in here. Better make a code cleanup issue?)

    $operations = parent::getOperations($entity);
    // no edit and delete below
smustgrave’s picture

smustgrave commented

If anyone here is free please go review the core issue so this can be unblocked.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.x-dev » 2.x-dev

smustgrave opened merge request !5

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Parent issue landed so going to close this old one out.

WOoo!!

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

TNX

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.