Follow-up from #2072251: [meta] Modernize forms to use FormBase.

CommentFileSizeAuthor
#5 block-2072941-5.patch15.01 KBtim.plunkett
#5 interdiff.txt970 bytestim.plunkett
#2 issue-2072941.patch13.29 KBmarcingy

Comments

marcingy’s picture

marcingy commented
Assigned: Unassigned » marcingy
marcingy’s picture

marcingy commented
Status: Active » Needs review
StatusFileSize
new issue-2072941.patch13.29 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! Thanks.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, issue-2072941.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt970 bytes
new block-2072941-5.patch15.01 KB

Fixed the unit test.

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

As original patch was RTBC already I think I am ok to RBTC the test fix as none of the code I amended is touched.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.