Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php

Line 152: Unused local variable $view

CommentFileSizeAuthor
#4 remove-unused-vars-2072625-4.patch685 bytesmichaelhiiva
#4 interdiff-2072625-1-4.txt677 bytesmichaelhiiva
#1 core-remove-unused-vars-2072625-1.patch734 byteslegolasbo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Assigned: legolasbo » Unassigned
Status: Active » Needs review
StatusFileSize
new core-remove-unused-vars-2072625-1.patch734 bytes

Removed unused variable

michaelhiiva’s picture

michaelhiiva commented
Status: Needs review » Reviewed & tested by the community

Patch applies, removes unused local variable $view.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php
@@ -149,7 +149,7 @@ protected function _testBetween() {
+    views_get_view('test_filter_date_between');

This whole line can be removed - it is unnecessary for the test.

michaelhiiva’s picture

michaelhiiva commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2072625-1-4.txt677 bytes
new remove-unused-vars-2072625-4.patch685 bytes

Patch with whole line removed.

areke’s picture

areke commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly; it looks good. Thank you!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.