#2059245: Add a FormBase class containing useful methods provides an easier way to define forms.
This issue is for going through existing forms and converting them.

Module name Issue
action #2071485: Modernize action.module forms
aggregator #2072249: Modernize aggregator.module forms
ajax_test #2077955: Modernize ajax_test.module forms Assigned to: RoSk0
automated_cron #2688229: Modernize automated_cron.module forms
ban #2072351: Modernize ban.module forms.
block #2072941: Modernize block.module forms Assigned to: marcingy
book #2072369: Modernize book.module forms
condition_test #2078013: Modernize condition_test.module forms Assigned to: RoSk0
config #2071439: Modernize config.module forms
contact #2072897: Modernize contact.module forms
content_translation #2077975: Modernize content_translation.module forms
custom_block #2060865: Modernize custom_block.module forms Assigned to: benjy
edit #2077971: Modernize edit.module forms
editor #2077973: Modernize editor.module forms
entity #2073075: Don't call the t() function in OO code in the field_ui module Assigned to: vanilla-bear
field_ui #2071493: Modernize field_ui.module forms
file #2077977: Modernize file.module forms
filter #2077979: Modernize filter.module forms: use $this->t()
form_test #2071985: Modernize form_test.module forms
forum #2072845: Modernize taxonomy.module and forum.module forms
image #2071473: Modernize image.module forms
language #2077983: Modernize language.module forms
locale #2077985: Modernize locale.module forms
menu #2077989: Modernize menu.module forms
node #2077993: Modernize node.module forms
path #2077999: Modernize path.module forms
picture #2078001: Modernize responsive_image.module forms
search #2078005: Modernize search.module forms
shortcut #2073069: Modernize shortcut.module forms Assigned to: marcingy
simpletest #2078007: Modernize simpletest.module forms
system (excluding test modules) #2078009: Modernize system.module forms Assigned to: RoSk0
taxonomy #2072845: Modernize taxonomy.module and forum.module forms
user #2071481: Modernize user.module forms
views_ui #2072303: Modernize views_ui.module forms
views_test_data #2078015: Modernize views_test_data.module forms Assigned to: RoSk0
EntityConfirmFormBase #2095681: Modernize EntityConfirmFormBase to use FormBase methods Assigned to: RoSk0

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Updated issue summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Updated issue summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Updated issue summary.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue summary: View changes

Add contact link

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

taxo/forum

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue summary: View changes

Add block ticket

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue summary: View changes

Add shortcut

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue summary: View changes

Add entity

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

Updated issue summary with test_ajax

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

typo

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

Updated issue summary.

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

Updated issue summary.

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

added links to new issues

alexanansi’s picture

alexanansi CreditAttribution: alexanansi commented
Issue summary: View changes

added two new issue links

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: tim.plunkett » Unassigned
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Added the custom_block module.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 commented
Issue summary: View changes

Added issue with EntityConfirmFormBase https://drupal.org/node/2095681.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 commented
Issue summary: View changes

Fixed token position for views_test_data module.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +Needs beta evaluation

At first glance this does not seem like something that is in scope for 8.0.x anymore during the beta. Let's add a beta evaluation, and if appropriate, postpone the issue?

Reference: https://www.drupal.org/core/beta-changes | Contributor task:

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.0.x-dev » 8.2.x-dev
Issue tags: -Needs beta evaluation

These changes could be added to the next development minor, since form builders are considered internal. Surprised there are any of the old ones left though.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented

Pretty sure they're all using FormBase now, IIRC those issues are mostly just switching from t() to $this->t()

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Closed (fixed)

Discussed with @xjm. Given that #2059245: Add a FormBase class containing useful methods and #1946434: Convert all of confirm_form() in node.admin.inc and node.pages.inc to the new form interface have landed I think we should close this meta. The forms have been modernised. The current open patches that are doing t() to $this->t() conversions. I think we need to adjust those issues scope and look for other related and duplicate issues - @xjm says that there is probably a deprecate t() issue. All t() usage in non-static methods in classes is suspect and should be removed. We need get a rule added to coder to find this and come up with a plan how to do all the work sensibly in core. For more on scope issues see https://www.drupal.org/core/scope for guidelines and examples. Doing this work piecemeal will mean it'll never get done and there's a high chance we'll introduce regressions.