Updated: Comment 2
In #1938062-98: Convert the recent_comments block to a view @webchick said
- Similarly, what does "Use default settings" mean in terms of number of things in a block? We should tell people what the value is. (e.g. "10 (default settings)")
Change "Use default settings" to "10 (default settings)" and
Review by @webchick
"Use default settings" is changed to "10 (default settings)" in block config screen.
'Items per page' is changed to 'Items per block'.
None
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | vdc-2072181-4.patch | 1.62 KB | tim.plunkett |
| #4 | interdiff.txt | 857 bytes | tim.plunkett |
| #1 | block.png | 7.62 KB | dawehner |
| #1 | vdc-2072181-1.patch | 1.62 KB | dawehner |
Comments
Comment #1
dawehnerHere is a patch for it. The patch also fix the title on the views wizard.
Comment #2
jibranThis is great. RTBC for @webchick.
Comment #3
tstoecklerI think the wording should be reversed here. Given the example: You are not choosing to explicitly show 5 items, which FYI just happens to be the default. You are choosing to not override the default setting, which just happens to be 5 at this point in time. If you choose "5 (default settings)" now, and then change the view to show 10 instead of 5, then your block will show 10 items as well. That is not clear from the current labeling.
Also I think it should be "default setting" instead of "default settings".
Since this is only my suggestion marking "needs review" to gather some feedback, instead of "needs work".
Comment #4
tim.plunkettFixing typo, thanks @tstoeckler. The text is fine as is, and matches what was requested in the other issue.
Comment #5
alexpottCommitted 5fc01a8 and pushed to 8.x. Thanks!
Comment #6.0
(not verified) commentedUpdated issue summary.