Updated: Comment 0

Problem/Motivation

As realized during working on #2053519: Broken PHPUnit test with notices enabled for AJAX fails on View with "AJAX: Yes" it came clear that there needs to be a method on the AjaxResponse object to retrieve all commands,
so they can be changed before released into the wild.

Proposed resolution

Add an getCommands method which returns a list of commands by reference.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#10 vdc-2071145.patch4.03 KBdawehner
#1 ajax-2071145-1.patch4.04 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Issue tags: +Stalking Crell
StatusFileSize
new ajax-2071145-1.patch4.04 KB

Here it is together with a test.

Crell’s picture

Crell commented

There is no API change here, only an API addition.

dawehner’s picture

dawehner
Primary language German
commented

Does that mean we can get this in?

Crell’s picture

Crell commented

1: ajax-2071145-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Title: Allow to change the commands of an ajax response » Regression: Allow to change the commands of an ajax response
Category: Task » Bug report
Issue summary: View changes
Priority: Normal » Major

Let's use the regression tool for this issue.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Just wanted to see if the bot was still OK with it.

dawehner’s picture

dawehner
Primary language German
commented

Just wanted to justify to move it to major.

catch’s picture

catch
he/him
Primary language English
commented

1: ajax-2071145-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: ajax-2071145-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new vdc-2071145.patch4.03 KB

Just a rerole.

Status: Needs review » Needs work

The last submitted patch, 10: vdc-2071145.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

10: vdc-2071145.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

RTBC if green.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.