[D7] Google Tag Manager

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsgerrand1809298git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Sasha,
Please pay attention to the ventral.org report above.

Besides whose points, I'd like to highlight these:
- Drupal code and its GIT repo hosts only GPL'd content. In your .module file and other files, you have included Apache license. (Even if you'd like to release the code under GPL, you do not have to put it yourself. Drupal.org packaging system will add it automatically for you :) )

In _google_tag_manager_snippet(), you have used $containerId and $customName as raw input. As you have defined a new permission administer google tag manager, users with this permission can inject JavaScript to the page which gets executed.
Run the output through check_plain().
Also it does not seem to be making use of the HTTP status code before applying the JS stuff.

I think the admin menu link would fit better in Admin > Configuration > Content Authoring trail.

Good luck!

There is already a project application for Google Tag Manager (https://drupal.org/node/1813730), and it has multiple people actively discussing it. You should look at the work being done in that sandbox and maybe merge your efforts with theirs.

Bill,

Great Suggestion. We are just getting started. Looking forward to collaborating on this. My Developer is relatively new to Drupal so we won't be the lead.

Added missing closing UL tag.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

There is now a Google Tag Manager project: http://drupal.org/project/google_tag